-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron 16: python version in linux arm build agent is deprecated in node-gyp > 8 #137927
Electron 16: python version in linux arm build agent is deprecated in node-gyp > 8 #137927
Comments
/cc @joaomoreno I am gonna try using our buster images in this branch which has the required versions. QQ: I see that you have already tried buster in the past based on the config present here https://github.com/microsoft/vscode-linux-build-agent/tree/main/buster-arm64 , do you remember why stretch was chosen finally ? |
Don't really remember. Probably OS compat across our ARM users? If we can't avoid using strict, we could install Python 3.6 on the container. |
Debian stretch only provides python 3.5 as part of the python 3 package https://packages.debian.org/stretch/python3, anything higher we have to build from source on that container.
I will try to use stretch gcc toolchain on buster to keep the native module requirements unchanged. Given stretch is gonna get LTS EOL in June 2022, another good thing about bumping to a newer version. |
* chore: bump [email protected] * chore: bump [email protected] * chore: enable render process reuse * Revert "watcher - use `type` property for crash reporter location" This reverts commit bfa488d. * Revert "watcher - enable crash reports on linux (#136264)" This reverts commit af26148. * chore: enable crashpad on linux * chore: bump [email protected] * chore: update api changes * chore: bump @vscode/[email protected] * spec: skip non-context aware module unittests * chore: fix perf hook integration with node environment * fix: adopt fs api changes * chore: fix integration tests * chore: bump [email protected] * chore: bump [email protected] * temp(macOS): kill test instances in OSS * Revert "temp(macOS): kill test instances in OSS" This reverts commit b0d796c. * chore: update chromium version for clang downloader * some 💄 changes * align with changes * adopt more fs.rm * 💄 * chore: bump @vscode/[email protected] * fix layers check to account for duplicated types from node.js * update todo for type casts * smoke - fix compile issue * chore: update module cache * watcher - fix unhandled rejection (fix #137416) * ci: update node version * enable stack dumping * update electron types to 16.x * chore: bump @vscode/[email protected] Refs #137496 * fix layer issue * add `AbortSignal` to core types * chore: update linux compile flags Refs electron/electron@797723e * ci: fix linux build * ci: update github ci cache * ci: fix remote build in github ci * ci: better fix for remote build * chore: bump azure cache * chore: fix merge conflict * :chore: update to [email protected] * chore: bump @vscode/[email protected] * ci: update to gcc-4.9 for remote Refs #137659 * ci: switch to buster for linux arm Refs #137927 * ci: fix build on linux arm64 * ci: fix arm client compiler toolchain Refs #137927 * chore: bump [email protected] * ci: fix compile flags for the c toolchain * chore: bump [email protected] * Add experimental dark mode flag (#139109) * Add experimental dark mode flag * Apply PR feedback * chore: bump [email protected] * chore: bump [email protected] Fixes #138792 Fixes #139300 * chore: experimental highlight API * smoke - fix compile issue * FIXME: custom ELECTRON_RUN_AS_NODE with node worker * Revert "chore: bump [email protected]" This reverts commit 5fd01cf. * Revert "Revert "chore: bump [email protected]"" This reverts commit a7f1b73. * chore: fix github linux workflow * chore: address review feedback * chore: bump [email protected] * ci: revert to stretch distro for linux arm Refs #137927 * ci: force build * chore: update yarn.lock * address feedback * Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker" This reverts commit 7b48fa3. * ci: fix remote folder build * chore: fix github linux ci * 🆙 `versionSpec` Co-authored-by: Benjamin Pasero <[email protected]> Co-authored-by: Raymond Zhao <[email protected]>
Currently we use Debian stretch for arm build agents which does not get Python >= 3.6 from its stable repository leading to the following error.
The text was updated successfully, but these errors were encountered: