Update setting name to be more extensible in the future

Discussed in microsoft/TypeScript#46590 (comment)
microsoft · Nov 19, 2021 · e784e88 · e784e88
1 parent 9939a82
commit e784e88
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json
@@ -1116,16 +1116,16 @@
           "markdownDescription": "%typescript.workspaceSymbols.scope%",
           "scope": "window"
         },
-        "javascript.suggest.includeCompletionsWithClassMemberSnippets": {
+        "javascript.suggest.classMemberSnippets.enabled": {
           "type": "boolean",
           "default": true,
-          "description": "%configuration.suggest.includeCompletionsWithClassMemberSnippets%",
+          "description": "%configuration.suggest.classMemberSnippets.enabled%",
           "scope": "resource"
         },
-        "typescript.suggest.includeCompletionsWithClassMemberSnippets": {
+        "typescript.suggest.classMemberSnippets.enabled": {
           "type": "boolean",
           "default": true,
-          "description": "%configuration.suggest.includeCompletionsWithClassMemberSnippets%",
+          "description": "%configuration.suggest.classMemberSnippets.enabled%",
           "scope": "resource"
         }
       }

diff --git a/extensions/typescript-language-features/package.nls.json b/extensions/typescript-language-features/package.nls.json
@@ -184,5 +184,5 @@
 	"codeActions.refactor.rewrite.property.generateAccessors.description": "Generate 'get' and 'set' accessors",
 	"codeActions.source.organizeImports.title": "Organize imports",
 	"typescript.findAllFileReferences": "Find File References",
-	"configuration.suggest.includeCompletionsWithClassMemberSnippets": "Enable/disable snippet completions for class members. Requires using TypeScript 4.5+ in the workspace"
+	"configuration.suggest.classMemberSnippets.enabled": "Enable/disable snippet completions for class members. Requires using TypeScript 4.5+ in the workspace"
 }
diff --git a/extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts b/extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts
@@ -186,7 +186,7 @@ export default class FileConfigurationManager extends Disposable {
 			generateReturnInDocTemplate: config.get<boolean>('suggest.jsdoc.generateReturns', true),
 			includeCompletionsForImportStatements: config.get<boolean>('suggest.includeCompletionsForImportStatements', true),
 			includeCompletionsWithSnippetText: config.get<boolean>('suggest.includeCompletionsWithSnippetText', true),
-			includeCompletionsWithClassMemberSnippets: config.get<boolean>('suggest.includeCompletionsWithClassMemberSnippets', true),
+			includeCompletionsWithClassMemberSnippets: config.get<boolean>('suggest.classMemberSnippets.enabled', true),
 			allowIncompleteCompletions: true,
 			displayPartsForJSDoc: true,
 			...getInlayHintsPreferences(config),