Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code #16877

Merged
merged 15 commits into from
Sep 16, 2021
Merged

Remove old code #16877

merged 15 commits into from
Sep 16, 2021

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Aug 6, 2021

Removes Following things:

  1. rope : Substituted by refactoring support from JediLSP or Pylance
  2. ctags: Substituted by workspace symbol support from JediLSP or Pylance
  3. Removes pylint minimal checkers setting

For #11995
Closes #10440
Closes #13321
Closes #16063

karthiknadig and others added 5 commits August 5, 2021 21:21
* Remove default pylint when using jedi

* Remove pylint minimal checkers

* Remove more pylint config

* Restore missed configuration file names

* More linting clean up

* Fix tests
* Add the 'security-events' permission to the CodeQL workflow (microsoft#16071)

* Delete misc files we don't need anymore

Co-authored-by: Brett Cannon <[email protected]>
@kimadeline
Copy link

Do you want me to take a first look, or is it for later?

@karthiknadig
Copy link
Member Author

karthiknadig commented Aug 10, 2021

Not for review but this is how far i got to removing the old code. you can continue from this point.

@kimadeline kimadeline added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Sep 15, 2021
@kimadeline kimadeline marked this pull request as ready for review September 16, 2021 16:48
@kimadeline kimadeline merged commit c94b1f4 into microsoft:main Sep 16, 2021
@karthiknadig karthiknadig deleted the remove-old-code branch November 4, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
2 participants