Change hot exit to create new files for each backup #12377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 16, 2020
| const id = this.storage.getBackupId(model); | ||
| this.storage.backup(model, cancellation).ignoreErrors(); | ||
| const id = this.storage.generateBackupId(model); | ||
| await this.storage.backup(model, cancellation, id); |
There was a problem hiding this comment.
I think awaiting here screwed up the custom editor. Can you try it an make sure it still works?
DonJayamanne
commented
Jun 16, 2020
| return { | ||
| id, | ||
| delete: () => this.storage.deleteBackup(model).ignoreErrors() // This cleans up after save has happened. | ||
| delete: () => this.storage.deleteBackup(model, id).ignoreErrors() // This cleans up after save has happened. |
There was a problem hiding this comment.
Delete the back associated with this id, hence passing the id.
DonJayamanne
commented
Jun 16, 2020
| @@ -175,12 +175,16 @@ export class NativeEditorProvider implements INotebookEditorProvider, CustomEdit | |||
| return this.open(uri); | |||
| } | |||
|
|
|||
| public async loadModel(file: Uri, contents?: string, skipDirtyContents?: boolean) { | |||
| public async loadModel(file: Uri, contents?: string, skipDirtyContents?: boolean): Promise<INotebookModel>; | |||
There was a problem hiding this comment.
Backwards compatibility with old code, hopefully when custom editor is used we can blow away skipDirtyContents completely..
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
DavidKutu,
greazer,
joyceerhl and
techwithtim
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
approved these changes
Jun 16, 2020
DavidKutu
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12376
For #10496
Changes due to the way VSC works.
Fix for VSC Notebooks and Custom Editor (