Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open profiles in untitled editors on complete #432

Closed
connor4312 opened this issue Apr 15, 2020 · 2 comments
Closed

Open profiles in untitled editors on complete #432

connor4312 opened this issue Apr 15, 2020 · 2 comments
Assignees
@connor4312
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone
April 2020

Comments

@connor4312
Copy link
Member

For use with the profile visualizer.

Currently blocked on microsoft/vscode#93441 -- until then profiles will be opened up as an unfriendly wall of JSON.
@connor4312 connor4312 self-assigned this Apr 15, 2020
@connor4312 connor4312 added the feature-request Request for new features or functionality label Apr 15, 2020
connor4312 added a commit that referenced this issue Apr 15, 2020
@connor4312
feat: open profile in untitled editor
4f48f0a 
Fixes #432
@connor4312 connor4312 added this to the April 2020 milestone Apr 15, 2020
@connor4312 connor4312 mentioned this issue Apr 15, 2020
Closed
9 tasks
@connor4312
Copy link
Member Author

Untitled editors can't be opened for custom webviews. Instead we now save the profile in the workspace and open it as a normal file.

@connor4312 connor4312 added the verification-needed Verification of issue is requested label Apr 27, 2020
@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Apr 29, 2020
@aeschli
Copy link

aeschli commented Apr 29, 2020

image

Taking a snapshor was not so easy, but found an context menu item on the call stack :-)

@Kingcrypto38 Kingcrypto38 mentioned this issue Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@connor4312 @aeschli