Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Commit

Permalink
github/workflows: use npm install and change version to X.Y.Z format
Browse files Browse the repository at this point in the history
semver package is unhappy about X.Y.Z.W format of version string
and leave the extension in invalid state. Now make semver happy.

Also, use npm install to ensure all test dependencies are pulled in.
  • Loading branch information
hyangah committed Mar 19, 2020
1 parent d585479 commit 9bf48fc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
go-version: '1.14'

- name: Install dependencies
run: npm ci
run: npm install

- name: Install Go tools (Modules mode)
run: |
Expand Down
5 changes: 4 additions & 1 deletion build/all.bash
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ run_test_in_docker() {
}

prepare_nightly() {
local VER=`git log -1 --format=%cd --date="format:%Y.%-m.%-d.%-H"`
# Version format: YYYY.MM.DDHH based on the latest commit timestamp.
# e.g. 2020.1.510 is the version built based on a commit that was made
# on 2020/01/05 10:00
local VER=`git log -1 --format=%cd --date="format:%Y.%-m.%-d%H"`
local COMMIT=`git log -1 --format=%H`
echo "**** Preparing nightly release : $VER ***"

Expand Down

0 comments on commit 9bf48fc

Please sign in to comment.