[anari] Update to 0.12.0 #43188
Open
[anari] Update to 0.12.0 #43188
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Jan 10, 2025
ports/anari/portfile.cmake
Outdated
Comment on lines
16
to
25
| -DBUILD_EXAMPLES=OFF | ||
| -DBUILD_VIEWER=OFF | ||
| -DBUILD_CTS=OFF | ||
| -DBUILD_EXAMPLES=OFF | ||
| -DBUILD_HDANARI=OFF | ||
| -DBUILD_HELIDE_DEVICE=OFF | ||
| -DBUILD_REMOTE_DEVICE=OFF | ||
| -DBUILD_TESTING=OFF | ||
| -DBUILD_VIEWER=OFF | ||
| -DINSTALL_CODE_GEN_SCRIPTS=ON | ||
| -DINSTALL_VIEWER_LIBRARY=ON |
There was a problem hiding this comment.
Maybe it is better to keep alphabetical order, to avoid dupliation (as now for BUILD_EXAMPLES)?
ports/anari/portfile.cmake
Outdated
Comment on lines
46
to
51
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/bin" | ||
| "${CURRENT_PACKAGES_DIR}/debug/bin" | ||
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/bin" | ||
| "${CURRENT_PACKAGES_DIR}/debug/bin" | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
It is not introduced by this PR, but ... explicit removal of bin is often a misguided approach to deal with tools. (Tool must also be handled for shared linkage. The right approach is vcpkg_copy_tools(... AUTO_CLEAN).)
There was a problem hiding this comment.
I removed the full clause. No tool or alike are installed there with the new version and the updated set of compile flags.
JonLiu1993
added
the
category:port-update
Nothing gets installed in there with the new set of flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.