-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add new community triplet x86-windows-static-release #29034
Conversation
Tagging requires: vcpkg-team-review because I want to confirm the team is OK with this. The triplet on its face as a thing to do is reasonable, but I think we want to make sure we're principled about not necessarily creating the cross product of possible settings. |
@ras0219-msft @markle11m @JavierMatosD @dan-shaw and I discussed this today. We think there needs to be some set of guidelines for what community triplets we add. To be a triplet it needs to be tested in our CI. We think it might make sense to make tool changes that change the triplet system so that the obvious scheme ones are 'generated' automatically. In the medium term we are also looking to generate much of the triplet interaction by inspection of the consuming build system in manifest mode. Because this PR looks like it's just trying to fill an entry in the sparse matrix rather than a demonstrated end user requirement, we are going to close this PR. That does not mean that we wouldn't add this community triplet if a meaningful number of users who would benefit is demonstrated. (If you are a user who is supplying this triplet regularly with an overlay, please respond here!) Thanks for your contribution to vcpkg, and sorry we didn't land this! |
In fact, I do use this triplet. I use it on making a windows virtual camera (with dshow lib). And it need provide both x64 and x86 dll to make both x86 and x64 client work. And I want these dll independs with vc runtime. So I would like to link to static runtime and other libs. That why I add such a triplet. And I believe there should be other similar situation. |
Just have an extra folder with triplets and define that folder as an overlay? I mean I do that for https://github.com/Neumann-A/my-vcpkg-triplets |
That is inneed what I need, thank you! |
Describe the pull request
Since there are
x64-windows-static-release
,arm-windows-static-release
,arm64-windows-static-release
and missingx86-windows-static-release
. We should also add this.x86-windows-static-release