use new getNativeModel method in get_surrogate_booster_pyspark to simplify erroranalysis code #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
- Coverage 87.27% 85.00% -2.27%
==========================================
Files 108 57 -51
Lines 5108 2881 -2227
==========================================
- Hits 4458 2449 -2009
+ Misses 650 432 -218
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
imatiach-msft
force-pushed
the
ilmat/spark-booster-get-model
branch
from
e92c832 to
04e45eb
Compare
imatiach-msft
force-pushed
the
ilmat/spark-booster-get-model
branch
from
04e45eb to
314167a
Compare
imatiach-msft
force-pushed
the
ilmat/spark-booster-get-model
branch
from
314167a to
84cdfc9
Compare
…plify erroranalysis code
imatiach-msft
force-pushed
the
ilmat/spark-booster-get-model
branch
from
84cdfc9 to
40f5473
Compare
vinuthakaranth
approved these changes
Jul 5, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use new getNativeModel method in get_surrogate_booster_pyspark to simplify erroranalysis code.
The getNativeModel has just recently been added to synapseml in PR microsoft/SynapseML#1515. Now we can update the get_surrogate_booster_pyspark to use that instead of the custom logic to save/read from file when using error analysis in spark scenario.
Error Analysis on 4GB Higgs dataset in databricks cluster:
Checklist