Add support default.txt changelog name #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 29, 2022
|
Tested changes manually. LGTM! |
ghost
approved these changes
Mar 29, 2022
|
@alexander-smolyakov could you please take a look? |
|
@denis-tikhomirov please share test scenarios you covered here |
| } else { | ||
| tl.debug(`The name of the file ${changelogFile} is not a valid version code. Skipping it.`); | ||
| } | ||
| } | ||
|
|
||
| if (releaseNotes.length === 0 && fullDefaultChangelogPath !== '') { | ||
| const message: string = `'default.txt' release notes file is found. It is used for language code ${languageCode}`; |
There was a problem hiding this comment.
Why it should be required? Could it make sense to have it as optional instead?
There was a problem hiding this comment.
Sorry, see it, thanks! It will be used only if there are no other changelogs as default - so it's optional in general
anatolybolshakov
approved these changes
Mar 30, 2022
Description is updated with checked test cases |
Done. @alexander-smolyakov, please review this again. |
alexander-smolyakov
approved these changes
Mar 30, 2022
|
@mmrazik, please review this PR. |
|
Hey @mmrazik, could you please review and merge this PR? |
mmrazik
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: GooglePlayReleaseV4
Description: The changes adds default.txt changelog file to list of required changelog files for uploading.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y
Checklist:
Checked test cases: