Error on `override` used on dynamically named class members #60691

Andarist · 2024-12-05T10:28:41Z

weswigham · 2024-12-05T20:38:56Z

typescript-bot · 2024-12-05T20:39:01Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-12-05T21:00:39Z

@weswigham Here are the results of running the user tests with tsc comparing main and refs/pull/60691/merge:

Everything looks good!

typescript-bot · 2024-12-05T21:01:53Z

Hey @weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-05T21:21:23Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,841k (± 1.02%)}	_{194,836k (± 1.01%)}	_~	_193,019k	_196,696k	_{p=0.936 n=6}
_{Parse Time}	_{1.30s (± 0.79%)}	_{1.30s (± 1.02%)}	_~	_1.29s	_1.32s	_{p=0.804 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.79s (± 0.56%)}	_{9.76s (± 0.46%)}	_~	_9.72s	_9.83s	_{p=0.335 n=6}
_{Emit Time}	_{2.73s (± 0.85%)}	_{2.72s (± 0.46%)}	_~	_2.71s	_2.74s	_{p=0.615 n=6}
_{Total Time}	_{14.54s (± 0.36%)}	_{14.51s (± 0.42%)}	_~	_14.44s	_14.59s	_{p=0.335 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,804k (± 0.00%)}	_{1,225,814k (± 0.00%)}	_~	_1,225,740k	_1,225,916k	_{p=0.936 n=6}
_{Parse Time}	_{6.67s (± 0.52%)}	_{6.66s (± 0.51%)}	_~	_6.60s	_6.69s	_{p=0.683 n=6}
_{Bind Time}	_{1.88s (± 0.27%)}	_{1.89s (± 0.40%)}	_~	_1.88s	_1.90s	_{p=0.069 n=6}
_{Check Time}	_{32.06s (± 0.32%)}	_{31.98s (± 0.16%)}	_~	_31.91s	_32.06s	_{p=0.199 n=6}
_{Emit Time}	_{15.20s (± 0.23%)}	_{15.15s (± 0.21%)}	_{-0.05s (- 0.33%)}	_15.11s	_15.19s	_{p=0.043 n=6}
_{Total Time}	_{55.82s (± 0.22%)}	_{55.68s (± 0.14%)}	_{-0.14s (- 0.25%)}	_55.58s	_55.78s	_{p=0.045 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,501,823	_2,501,823	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,645	_909,645	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,319,320k (± 0.00%)}	_{2,319,310k (± 0.00%)}	_~	_2,319,284k	_2,319,326k	_{p=0.422 n=6}
_{Parse Time}	_{9.28s (± 0.33%)}	_{9.30s (± 0.38%)}	_~	_9.27s	_9.36s	_{p=0.366 n=6}
_{Bind Time}	_{2.17s (± 0.64%)}	_{2.16s (± 0.80%)}	_~	_2.14s	_2.18s	_{p=0.739 n=6}
_{Check Time}	_{74.82s (± 0.55%)}	_{74.83s (± 0.31%)}	_~	_74.59s	_75.14s	_{p=0.748 n=6}
_{Emit Time}	_0.28s	_{0.28s (± 3.19%)}	_~	_0.27s	_0.29s	_{p=1.000 n=6}
_{Total Time}	_{86.55s (± 0.46%)}	_{86.58s (± 0.27%)}	_~	_86.32s	_86.87s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,304	_1,225,330	_{+26 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,555	_266,569	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,354,508k (± 0.02%)}	_{2,354,273k (± 0.02%)}	_~	_2,353,931k	_2,355,025k	_{p=0.298 n=6}
_{Parse Time}	_{5.20s (± 0.63%)}	_{5.24s (± 1.12%)}	_~	_5.15s	_5.30s	_{p=0.336 n=6}
_{Bind Time}	_{1.77s (± 0.66%)}	_{1.78s (± 0.83%)}	_~	_1.76s	_1.80s	_{p=0.324 n=6}
_{Check Time}	_{35.26s (± 0.27%)}	_{35.24s (± 0.36%)}	_~	_35.04s	_35.37s	_{p=1.000 n=6}
_{Emit Time}	_{2.94s (± 2.10%)}	_{2.96s (± 1.42%)}	_~	_2.93s	_3.04s	_{p=1.000 n=6}
_{Total Time}	_{45.19s (± 0.23%)}	_{45.23s (± 0.34%)}	_~	_45.03s	_45.39s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,304	_1,225,330	_{+26 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,555	_266,569	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,029,108k (± 9.78%)}	_{2,935,143k (±11.48%)}	_~	_2,425,200k	_3,150,920k	_{p=1.000 n=6}
_{Parse Time}	_{6.97s (± 1.31%)}	_{6.95s (± 1.72%)}	_~	_6.78s	_7.08s	_{p=0.872 n=6}
_{Bind Time}	_{2.17s (± 0.69%)}	_{2.18s (± 1.53%)}	_~	_2.15s	_2.23s	_{p=1.000 n=6}
_{Check Time}	_{42.76s (± 0.58%)}	_{42.74s (± 0.48%)}	_~	_42.37s	_42.88s	_{p=1.000 n=6}
_{Emit Time}	_{3.52s (± 1.86%)}	_{3.49s (± 2.62%)}	_~	_3.40s	_3.61s	_{p=0.575 n=6}
_{Total Time}	_{55.42s (± 0.51%)}	_{55.35s (± 0.48%)}	_~	_54.88s	_55.55s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,265	_262,269	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,616	_106,628	_{+12 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,853k (± 0.01%)}	_{439,902k (± 0.02%)}	_~	_439,767k	_440,072k	_{p=0.298 n=6}
_{Parse Time}	_{3.54s (± 0.68%)}	_{3.54s (± 0.73%)}	_~	_3.50s	_3.57s	_{p=0.518 n=6}
_{Bind Time}	_{1.32s (± 0.78%)}	_{1.31s (± 0.93%)}	_~	_1.30s	_1.33s	_{p=0.153 n=6}
_{Check Time}	_{18.95s (± 0.35%)}	_{18.94s (± 0.36%)}	_~	_18.86s	_19.01s	_{p=0.686 n=6}
_{Emit Time}	_{1.53s (± 1.15%)}	_{1.53s (± 0.49%)}	_~	_1.52s	_1.54s	_{p=0.493 n=6}
_{Total Time}	_{25.34s (± 0.27%)}	_{25.32s (± 0.28%)}	_~	_25.21s	_25.40s	_{p=0.689 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,585k (± 0.02%)}	_{371,715k (± 0.09%)}	_~	_371,518k	_372,370k	_{p=0.936 n=6}
_{Parse Time}	_{2.91s (± 0.42%)}	_{2.91s (± 1.06%)}	_~	_2.86s	_2.95s	_{p=0.681 n=6}
_{Bind Time}	_{1.60s (± 0.86%)}	_{1.59s (± 1.77%)}	_~	_1.56s	_1.64s	_{p=0.252 n=6}
_{Check Time}	_{16.48s (± 0.49%)}	_{16.48s (± 0.15%)}	_~	_16.46s	_16.53s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.99s (± 0.47%)}	_{20.98s (± 0.18%)}	_~	_20.91s	_21.02s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,197,659	_3,197,659	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,099,203	_1,099,203	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,271,515k (± 0.01%)}	_{3,271,427k (± 0.01%)}	_~	_3,271,102k	_3,271,994k	_{p=0.378 n=6}
_{Parse Time}	_{14.11s (± 0.28%)}	_{14.13s (± 0.74%)}	_~	_14.00s	_14.25s	_{p=0.575 n=6}
_{Bind Time}	_{4.53s (± 0.43%)}	_{4.57s (± 2.20%)}	_~	_4.48s	_4.76s	_{p=0.627 n=6}
_{Check Time}	_{87.61s (± 1.59%)}	_{88.28s (± 2.01%)}	_~	_86.45s	_90.16s	_{p=0.575 n=6}
_{Emit Time}	_{28.24s (± 2.46%)}	_{28.17s (± 2.63%)}	_~	_27.37s	_28.96s	_{p=1.000 n=6}
_{Total Time}	_{134.49s (± 0.55%)}	_{135.15s (± 0.83%)}	_~	_133.79s	_136.53s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,747	_288,747	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,158	_117,158	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,977k (± 0.03%)}	_{441,040k (± 0.03%)}	_~	_440,887k	_441,261k	_{p=0.471 n=6}
_{Parse Time}	_{4.07s (± 0.29%)}	_{4.09s (± 0.97%)}	_~	_4.05s	_4.16s	_{p=0.568 n=6}
_{Bind Time}	_{1.78s (± 2.12%)}	_{1.76s (± 1.11%)}	_~	_1.73s	_1.78s	_{p=0.089 n=6}
_{Check Time}	_{18.83s (± 0.58%)}	_{18.89s (± 0.41%)}	_~	_18.77s	_18.98s	_{p=0.298 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.68s (± 0.57%)}	_{24.75s (± 0.43%)}	_~	_24.62s	_24.92s	_{p=0.520 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,389	_552,389	_~	_~	_~	_{p=1.000 n=6}
_Types	_185,093	_185,093	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,501k (± 0.00%)}	_{492,508k (± 0.01%)}	_~	_492,441k	_492,553k	_{p=0.575 n=6}
_{Parse Time}	_{3.41s (± 1.28%)}	_{3.42s (± 0.86%)}	_~	_3.39s	_3.47s	_{p=0.685 n=6}
_{Bind Time}	_{1.18s (± 1.17%)}	_{1.17s (± 1.86%)}	_~	_1.14s	_1.19s	_{p=0.413 n=6}
_{Check Time}	_{19.45s (± 0.19%)}	_{19.47s (± 0.46%)}	_~	_19.37s	_19.62s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.04s (± 0.19%)}	_{24.05s (± 0.49%)}	_~	_23.95s	_24.28s	_{p=0.686 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-12-05T22:08:51Z

@weswigham Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60691/merge:

Everything looks good!

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Dec 5, 2024

Andarist force-pushed the error-on-override-with-dynamic-names branch from f334978 to b5f37ca Compare December 5, 2024 10:31

Error on override used on dynamically named class members

e3d4463

Andarist force-pushed the error-on-override-with-dynamic-names branch from b5f37ca to e3d4463 Compare December 5, 2024 10:55

weswigham approved these changes Dec 5, 2024

View reviewed changes

weswigham added the Breaking Change Would introduce errors in existing code label Dec 5, 2024

weswigham added this to the TypeScript 5.8.0 milestone Dec 5, 2024

weswigham merged commit 239a2a9 into microsoft:main Dec 6, 2024
32 checks passed

DanielRosenwasser mentioned this pull request Dec 6, 2024

Design Meeting Notes, 12/6/2024 #60708

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error on `override` used on dynamically named class members #60691

Error on `override` used on dynamically named class members #60691

Andarist commented Dec 5, 2024

weswigham commented Dec 5, 2024

typescript-bot commented Dec 5, 2024 •

edited

Loading

typescript-bot commented Dec 5, 2024

typescript-bot commented Dec 5, 2024

typescript-bot commented Dec 5, 2024

tsc

typescript-bot commented Dec 5, 2024

Error on override used on dynamically named class members #60691

Error on override used on dynamically named class members #60691

Conversation

Andarist commented Dec 5, 2024

weswigham commented Dec 5, 2024

typescript-bot commented Dec 5, 2024 • edited Loading

typescript-bot commented Dec 5, 2024

typescript-bot commented Dec 5, 2024

typescript-bot commented Dec 5, 2024

tsc

typescript-bot commented Dec 5, 2024

Error on `override` used on dynamically named class members #60691

Error on `override` used on dynamically named class members #60691

typescript-bot commented Dec 5, 2024 •

edited

Loading