Reuse cached resolved signatures early #60208

Andarist · 2024-10-12T13:41:36Z

Andarist · 2024-10-12T14:02:25Z

tests/baselines/reference/mixinWithBaseDependingOnSelfNoCrash1.errors.txt

+      BaseClass extends new (...args: any[]) => any,
+    >(Base: BaseClass): any;
+
+    declare class Item extends ClientDocumentMixin(BaseItem) {}


due to the circular nature of this example, the compiler goes into resolveCall for the same node twice in a nested manner

the first getResolvedSignature ends up calling resolveAnonymousTypeMembers for typeof BaseItem

in the process it preemptively sets empty signatures, members, index infos on that type here

but then it also computes real construct signatures here

this in turn leads to calling getResolvedSignature again for the same node and all

in that inner call we see no construct signatures on typeof BaseItem (those were set to an empty array) so the error is raised because signaturesRelatedTo fails to determine that this source (typeof BaseItem) has the required target signatures

this inner call errors and exits, caching the getCandidateForOverloadFailure's result as the links.resolvedSignature. That signature is (Base: new (...args: any[]) => any): any

this leads to resolving (): BaseItem as getDefaultConstructSignatures and that replaces the empty construct signatures preemptively set by resolveAnonymousTypeMembers

now we climb up the stack, going back to the first/outer getResolvedSignature call for this. When calling getSignatureApplicabilityError the compiler returns an error because it reuses cached RelationComparisonResult.Failed that was cached when relating the argument and parameter types in that inner call

so now the compiler computes getCandidateForOverloadFailure again and tries to elaborate this error (again!).

this time it succeeds when relating those 2 types because the construct signatures of typeof BaseItem changed "in-between". So the debug assert kicks finally kicks in and the compiler crashes

Thanks a ton for this PR and the explanation! It makes the crash make much more sense to me now.

I will say some of these steps still seem to have a bit of concerning logic and seem to help explain something else weird I noted on my issue, namely that there doesn't have to be a "real" loop in the base type for you to get an error like Argument of type 'typeof BaseItem' is not assignable to parameter of type 'new (...args: any[]) => any'.

Playground (make sure to make any edit to overcome the crash and view an error!)

tbh your example is somewhat convoluted to the point that I'm not sure if it should error or not. It's definitely outside of the "regular TS" territory 😅 so all I was after here was to fix the crash. Once this gets fixed you might want to raise a new issue about the circularity issue if you thing it shouldn't be reported

jakebailey · 2024-10-12T22:30:27Z

@typescript-bot test it

typescript-bot · 2024-10-12T22:30:31Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-12T22:52:30Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-12T22:56:41Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60208/merge:

Everything looks good!

typescript-bot · 2024-10-12T23:11:58Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,901k (± 0.09%)}	_{192,859k (± 0.07%)}	_~	_192,793k	_193,115k	_{p=0.810 n=6}
_{Parse Time}	_{1.30s (± 1.37%)}	_{1.31s (± 0.62%)}	_~	_1.30s	_1.32s	_{p=0.157 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.72s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.72s (± 0.27%)}	_{9.75s (± 0.31%)}	_~	_9.71s	_9.80s	_{p=0.170 n=6}
_{Emit Time}	_{2.72s (± 1.28%)}	_{2.72s (± 0.55%)}	_~	_2.70s	_2.74s	_{p=0.332 n=6}
_{Total Time}	_{14.47s (± 0.30%)}	_{14.50s (± 0.21%)}	_~	_14.46s	_14.54s	_{p=0.420 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,591k (± 0.00%)}	_{1,224,577k (± 0.00%)}	_~	_1,224,544k	_1,224,596k	_{p=0.688 n=6}
_{Parse Time}	_{6.66s (± 0.72%)}	_{6.64s (± 0.87%)}	_~	_6.59s	_6.73s	_{p=0.573 n=6}
_{Bind Time}	_{1.88s (± 0.27%)}	_1.88s	_~	_~	_~	_{p=0.174 n=6}
_{Check Time}	_{31.81s (± 0.27%)}	_{31.82s (± 0.38%)}	_~	_31.69s	_32.02s	_{p=0.936 n=6}
_{Emit Time}	_{15.18s (± 0.38%)}	_{15.13s (± 0.28%)}	_~	_15.07s	_15.17s	_{p=0.260 n=6}
_{Total Time}	_{55.52s (± 0.30%)}	_{55.47s (± 0.30%)}	_~	_55.29s	_55.67s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,530,075	_2,530,075	_~	_~	_~	_{p=1.000 n=6}
_Types	_916,374	_916,374	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,341,297k (± 0.00%)}	_{2,341,307k (± 0.00%)}	_~	_2,341,243k	_2,341,401k	_{p=0.936 n=6}
_{Parse Time}	_{9.37s (± 0.46%)}	_{9.39s (± 0.21%)}	_~	_9.36s	_9.41s	_{p=0.573 n=6}
_{Bind Time}	_{2.17s (± 0.45%)}	_{2.16s (± 0.45%)}	_~	_2.15s	_2.18s	_{p=0.211 n=6}
_{Check Time}	_{76.04s (± 0.35%)}	_{75.93s (± 0.49%)}	_~	_75.56s	_76.55s	_{p=0.378 n=6}
_{Emit Time}	_{0.28s (± 2.70%)}	_{0.27s (± 2.98%)}	_~	_0.27s	_0.29s	_{p=0.206 n=6}
_{Total Time}	_{87.86s (± 0.33%)}	_{87.75s (± 0.43%)}	_~	_87.39s	_88.39s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,110	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,146,212k (± 0.01%)}	_{3,146,853k (± 0.05%)}	_~	_3,145,282k	_3,148,807k	_{p=1.000 n=6}
_{Parse Time}	_{6.59s (± 0.47%)}	_{6.60s (± 0.84%)}	_~	_6.54s	_6.68s	_{p=0.936 n=6}
_{Bind Time}	_{2.32s (± 1.26%)}	_{2.28s (± 4.13%)}	_~	_2.09s	_2.33s	_{p=0.746 n=6}
_{Check Time}	_{42.99s (± 0.36%)}	_{42.94s (± 0.34%)}	_~	_42.75s	_43.11s	_{p=0.810 n=6}
_{Emit Time}	_{3.59s (± 1.88%)}	_{3.56s (± 2.06%)}	_~	_3.49s	_3.68s	_{p=0.422 n=6}
_{Total Time}	_{55.48s (± 0.20%)}	_{55.38s (± 0.38%)}	_~	_55.05s	_55.68s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,110	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,739,089k (±13.56%)}	_{2,859,044k (±13.74%)}	_~	_2,498,920k	_3,218,158k	_{p=0.689 n=6}
_{Parse Time}	_{6.65s (± 2.66%)}	_{6.68s (± 2.36%)}	_~	_6.54s	_6.90s	_{p=0.873 n=6}
_{Bind Time}	_{2.18s (± 4.35%)}	_{2.23s (± 4.50%)}	_~	_2.14s	_2.37s	_{p=0.172 n=6}
_{Check Time}	_{43.15s (± 0.23%)}	_{43.18s (± 0.41%)}	_~	_42.91s	_43.39s	_{p=0.689 n=6}
_{Emit Time}	_{3.47s (± 1.77%)}	_{3.54s (± 1.86%)}	_~	_3.44s	_3.61s	_{p=0.173 n=6}
_{Total Time}	_{55.47s (± 0.46%)}	_{55.63s (± 0.52%)}	_~	_55.13s	_55.93s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,786	_261,787	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_106,508	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,538k (± 0.01%)}	_{438,572k (± 0.01%)}	_~	_438,462k	_438,626k	_{p=0.173 n=6}
_{Parse Time}	_{2.90s (± 0.85%)}	_{2.90s (± 0.65%)}	_~	_2.88s	_2.92s	_{p=0.935 n=6}
_{Bind Time}	_{1.10s (± 0.47%)}	_1.10s	_~	_~	_~	_{p=0.174 n=6}
_{Check Time}	_{15.72s (± 0.24%)}	_{15.72s (± 0.31%)}	_~	_15.66s	_15.78s	_{p=1.000 n=6}
_{Emit Time}	_{1.30s (± 1.58%)}	_{1.31s (± 0.93%)}	_~	_1.29s	_1.32s	_{p=0.871 n=6}
_{Total Time}	_{21.03s (± 0.17%)}	_{21.02s (± 0.21%)}	_~	_20.96s	_21.08s	_{p=0.809 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,058k (± 0.01%)}	_{371,089k (± 0.01%)}	_~	_371,064k	_371,116k	_{p=0.054 n=6}
_{Parse Time}	_{2.89s (± 0.75%)}	_{2.88s (± 1.58%)}	_~	_2.84s	_2.95s	_{p=0.520 n=6}
_{Bind Time}	_{1.57s (± 1.11%)}	_{1.58s (± 0.77%)}	_~	_1.56s	_1.59s	_{p=0.744 n=6}
_{Check Time}	_{16.36s (± 0.28%)}	_{16.42s (± 0.12%)}	_{+0.06s (+ 0.36%)}	_16.39s	_16.44s	_{p=0.019 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.83s (± 0.21%)}	_{20.88s (± 0.30%)}	_~	_20.79s	_20.95s	_{p=0.171 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,117,487	_3,117,487	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,074,418	_1,074,418	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,210,903k (± 0.01%)}	_{3,210,927k (± 0.01%)}	_~	_3,210,173k	_3,211,292k	_{p=0.689 n=6}
_{Parse Time}	_{14.01s (± 0.32%)}	_{14.05s (± 0.63%)}	_~	_13.90s	_14.16s	_{p=0.229 n=6}
_{Bind Time}	_{4.43s (± 0.56%)}	_{4.45s (± 0.40%)}	_~	_4.42s	_4.47s	_{p=0.253 n=6}
_{Check Time}	_{86.44s (± 1.85%)}	_{85.36s (± 1.16%)}	_~	_83.84s	_86.77s	_{p=0.378 n=6}
_{Emit Time}	_{26.52s (± 5.23%)}	_{25.55s (± 8.17%)}	_~	_22.63s	_27.35s	_{p=0.173 n=6}
_{Total Time}	_{131.40s (± 1.90%)}	_{129.40s (± 1.69%)}	_~	_126.10s	_131.93s	_{p=0.199 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,224	_285,224	_~	_~	_~	_{p=1.000 n=6}
_Types	_115,781	_115,781	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{435,393k (± 0.04%)}	_{435,353k (± 0.03%)}	_~	_435,119k	_435,479k	_{p=0.689 n=6}
_{Parse Time}	_{5.04s (± 0.71%)}	_{5.04s (± 0.52%)}	_~	_5.00s	_5.07s	_{p=0.808 n=6}
_{Bind Time}	_{2.17s (± 1.78%)}	_{2.15s (± 1.48%)}	_~	_2.10s	_2.19s	_{p=0.169 n=6}
_{Check Time}	_{22.80s (± 0.59%)}	_{22.80s (± 0.65%)}	_~	_22.59s	_22.98s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.01s (± 0.52%)}	_{29.99s (± 0.58%)}	_~	_29.72s	_30.16s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,836k (± 0.01%)}	_{483,870k (± 0.01%)}	_~	_483,761k	_483,948k	_{p=0.261 n=6}
_{Parse Time}	_{4.18s (± 0.58%)}	_{4.17s (± 0.48%)}	_~	_4.14s	_4.20s	_{p=0.745 n=6}
_{Bind Time}	_{1.45s (± 0.83%)}	_{1.46s (± 0.72%)}	_~	_1.44s	_1.47s	_{p=1.000 n=6}
_{Check Time}	_{23.65s (± 0.36%)}	_{23.73s (± 0.20%)}	_~	_23.66s	_23.78s	_{p=0.054 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{29.28s (± 0.34%)}	_{29.36s (± 0.19%)}	_~	_29.29s	_29.43s	_{p=0.128 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-13T00:14:59Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60208/merge:

Everything looks good!

gabritto

Seems like a promising idea in the absence of the possibility of fixing the assignability result inconsistency, but I left a question.

src/compiler/checker.ts

gabritto · 2024-10-16T01:45:29Z

Maybe related fix: #49598

gabritto

Left a question.

Reuse cached resolved signatures early

c40b6ca

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 12, 2024

Andarist commented Oct 12, 2024

View reviewed changes

Andarist mentioned this pull request Oct 15, 2024

Debug Failure. No error for last overload signature #60229

Open

gabritto reviewed Oct 16, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

src/compiler/checker.ts Show resolved Hide resolved

gabritto self-assigned this Oct 18, 2024

gabritto requested changes Oct 18, 2024

View reviewed changes

add comment

cfb820c

Andarist requested a review from gabritto October 23, 2024 19:22

gabritto approved these changes Oct 23, 2024

View reviewed changes

jakebailey approved these changes Oct 23, 2024

View reviewed changes

gabritto merged commit 5e2e321 into microsoft:main Nov 6, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reuse cached resolved signatures early #60208

Reuse cached resolved signatures early #60208

Andarist commented Oct 12, 2024

Andarist Oct 12, 2024

LukeAbby Oct 12, 2024

Andarist Oct 13, 2024

jakebailey commented Oct 12, 2024

typescript-bot commented Oct 12, 2024 •

edited

Loading

typescript-bot commented Oct 12, 2024

typescript-bot commented Oct 12, 2024

typescript-bot commented Oct 12, 2024

tsc

typescript-bot commented Oct 13, 2024

gabritto left a comment

gabritto commented Oct 16, 2024

gabritto left a comment

Reuse cached resolved signatures early #60208

Reuse cached resolved signatures early #60208

Conversation

Andarist commented Oct 12, 2024

Andarist Oct 12, 2024

Choose a reason for hiding this comment

LukeAbby Oct 12, 2024

Choose a reason for hiding this comment

Andarist Oct 13, 2024

Choose a reason for hiding this comment

jakebailey commented Oct 12, 2024

typescript-bot commented Oct 12, 2024 • edited Loading

typescript-bot commented Oct 12, 2024

typescript-bot commented Oct 12, 2024

typescript-bot commented Oct 12, 2024

tsc

typescript-bot commented Oct 13, 2024

gabritto left a comment

Choose a reason for hiding this comment

gabritto commented Oct 16, 2024

gabritto left a comment

Choose a reason for hiding this comment

typescript-bot commented Oct 12, 2024 •

edited

Loading