Fixed quick fixes for inferred type predicates #58958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Jul 25, 2024
Comment on lines
+1113
to
+1121
| const result = typePredicateToAutoImportableTypeNode(typeChecker, importAdder, typePredicate, enclosingDeclaration, scriptTarget, declarationEmitNodeBuilderFlags | flags, { | ||
| moduleResolverHost: program, | ||
| trackSymbol() { | ||
| return true; | ||
| }, | ||
| reportTruncationError() { | ||
| isTruncated = true; | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This looks pretty much the same as typeToTypeNode; why is it that we need a second set of helpers for type predicates? Why can't typeToAutoImportableTypeNode "just work" for these cases?
There was a problem hiding this comment.
Because type predicates are neither types nor type nodes 😢
jakebailey
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58948