Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go To Source Definition in --moduleResolution bundler #53613

Merged
merged 8 commits into from
Mar 31, 2023
Merged

Fix Go To Source Definition in --moduleResolution bundler #53613

merged 8 commits into from
Mar 31, 2023

Conversation

andrewbranch
Copy link
Member

Happened to notice that require wasn’t being followed while I was working on microsoft/vscode#178840

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 31, 2023
@andrewbranch andrewbranch marked this pull request as draft March 31, 2023 20:19
@andrewbranch andrewbranch marked this pull request as ready for review March 31, 2023 20:29
@andrewbranch
Copy link
Member Author

I’d really like to get this into a patch. It should be safe, since noDtsResolution is internal and only used by Go To Source Definition.

jakebailey
jakebailey approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me but CI is failing 😄

@andrewbranch
Copy link
Member Author

I’m trying to go too fast and thereby going slow 😅

jakebailey
jakebailey approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x2

@andrewbranch
Copy link
Member Author

@typescript-bot cherry-pick to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2023 •
edited
Loading

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-5.0 on this PR at aa4e912. You can monitor the build here.

@andrewbranch andrewbranch added this to the TypeScript 5.0.4 milestone Mar 31, 2023
@andrewbranch andrewbranch merged commit 9052ef8 into microsoft:main Mar 31, 2023
@andrewbranch andrewbranch deleted the bug/go-to-source-def-bundler branch March 31, 2023 22:53
@typescript-bot typescript-bot mentioned this pull request Mar 31, 2023
Merged
@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #53617 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 31, 2023
@andrewbranch @typescript-bot
Cherry-pick PR microsoft#53613 into release-5.0
c7f4997 
Component commits:
449b6e6 Fix Go To Source Definition in --moduleResolution bundler

1fddb2a Accept baseline

8c81daf Actually fix it

e8f7120 Remove unnecessary function calls

47ae29a Fix bad edits

4dd8655 Fix lint

2d362be Fix lint

aa4e912 Fix lint
DanielRosenwasser pushed a commit that referenced this pull request Apr 5, 2023
@andrewbranch
🤖 Pick PR #53613 (Fix Go To Source Definition in `--m...) into releas…
365cb58 
…e-5.0 (#53617)

Co-authored-by: Andrew Branch <[email protected]>
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
@andrewbranch
🤖 Pick PR microsoft#53613 (Fix Go To Source Definition in `--m...) in…
fb32f79 
…to release-5.0 (microsoft#53617)

Co-authored-by: Andrew Branch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@jakebailey jakebailey jakebailey approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
TypeScript 5.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewbranch @typescript-bot @jakebailey @sheetalkamat