Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #29168 #29174

Closed
wants to merge 1 commit into from
Closed

Fix #29168 #29174

wants to merge 1 commit into from

Conversation

jack-williams
Copy link
Collaborator

Fixes #29168

I'm slightly worried this is the wrong approach, and/or is a breaking change. Candidate PR up anyways.

@jack-williams jack-williams mentioned this pull request Dec 28, 2018
Closed
weswigham
weswigham approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the right change to make, IMO.

@jack-williams jack-williams mentioned this pull request Jan 18, 2019
Merged
@jack-williams
Copy link
Collaborator Author

jack-williams commented Jan 19, 2019 •
edited
Loading

Closing in favour of #29478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-williams @weswigham