fix(59463): Feature that displays method argument names inline does n…

…ot correctly handle method overloading (#59504)
microsoft · Oct 18, 2024 · df9d165 · df9d165
1 parent c07da58
commit df9d165
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 6 deletions.
diff --git a/src/services/inlayHints.ts b/src/services/inlayHints.ts
@@ -106,7 +106,6 @@ import {
     PrefixUnaryExpression,
     PropertyDeclaration,
     QuotePreference,
-    Signature,
     SignatureDeclarationBase,
     skipParentheses,
     some,
@@ -296,11 +295,8 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
             return;
         }
 
-        const candidates: Signature[] = [];
-        const signature = checker.getResolvedSignatureForSignatureHelp(expr, candidates);
-        if (!signature || !candidates.length) {
-            return;
-        }
+        const signature = checker.getResolvedSignature(expr);
+        if (signature === undefined) return;
 
         let signatureParamPos = 0;
         for (const originalArg of args) {

diff --git a/...reference/inlayHintsOverloadCall.baseline → ...eference/inlayHintsOverloadCall1.baseline b/...reference/inlayHintsOverloadCall.baseline → ...eference/inlayHintsOverloadCall1.baseline
diff --git a/tests/baselines/reference/inlayHintsOverloadCall2.baseline b/tests/baselines/reference/inlayHintsOverloadCall2.baseline
@@ -0,0 +1,18 @@
+// === Inlay Hints ===
+    { n: [1, 2, 3] },
+    ^
+{
+  "text": "ok_1:",
+  "position": 195,
+  "kind": "Parameter",
+  "whitespaceAfter": true
+}
+
+    {
+    ^
+{
+  "text": "ok_2:",
+  "position": 217,
+  "kind": "Parameter",
+  "whitespaceAfter": true
+}
diff --git a/...cases/fourslash/inlayHintsOverloadCall.ts → ...ases/fourslash/inlayHintsOverloadCall1.ts b/...cases/fourslash/inlayHintsOverloadCall.ts → ...ases/fourslash/inlayHintsOverloadCall1.ts
diff --git a/tests/cases/fourslash/inlayHintsOverloadCall2.ts b/tests/cases/fourslash/inlayHintsOverloadCall2.ts
@@ -0,0 +1,23 @@
+/// <reference path="fourslash.ts" />
+
+////type HasID = {
+////    id: number;
+////}
+////
+////type Numbers = {
+////    n: number[];
+////}
+////
+////declare function func(bad1: number, bad2: HasID): void;
+////declare function func(ok_1: Numbers, ok_2: HasID): void;
+////
+////func(
+////    { n: [1, 2, 3] },
+////    {
+////        id: 1,
+////    },
+////);
+
+verify.baselineInlayHints(undefined, {
+    includeInlayParameterNameHints: "all",
+});