fix: add back diagnosticsInfo for MVAD #1892
Conversation
|
/azp run |
|
Hey @serena-ruan 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
==========================================
- Coverage 86.82% 86.76% -0.07%
==========================================
Files 301 301
Lines 15596 15621 +25
Branches 815 821 +6
==========================================
+ Hits 13541 13553 +12
- Misses 2055 2068 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -524,6 +526,13 @@ class SimpleDetectMultivariateAnomaly(override val uid: String) extends Model[Si | |||
|
|
|||
| def getModelId: String = $(modelId) | |||
|
|
|||
| val diagnosticsInfo = new CognitiveServiceStructParam[DiagnosticsInfo](this, "diagnosticsInfo", | |||
There was a problem hiding this comment.
What is this CognitiveServicesStruct param? Does this provide a general way of letting the python side create wrappers too? If so thats pretty awesome
There was a problem hiding this comment.
I thought I initially added this type of param to support extending JsonEncodableParam for cog service params, and used it for TextAnalyzeTask parameter, but looks like it's been removed and updated somehow.
This is kind of a structured param that is not service param, because it doesn't support Left/Right. And you're right, I should figure out how the python wrapper could access this value, I think right now it can't really access the value inside :(
I'll figure that out and add in this PR
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.