Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate old Text analytics APIs to prepare for refactor #1627

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

mhamilton723
Copy link
Collaborator

@mhamilton723 mhamilton723 commented Aug 23, 2022

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1942450

@github-actions
Copy link

Hey @mhamilton723 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #1627 (069be83) into master (2052e13) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1627      +/-   ##
==========================================
+ Coverage   83.53%   83.60%   +0.07%     
==========================================
  Files         288      288              
  Lines       15334    15334              
  Branches      747      747              
==========================================
+ Hits        12809    12820      +11     
+ Misses       2525     2514      -11     
Impacted Files Coverage Δ
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 86.25% <ø> (ø)
.../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala 86.01% <ø> (ø)
.../execution/streaming/continuous/HTTPSourceV2.scala 92.08% <0.00%> (-0.72%) ⬇️
...se/ml/cognitive/MultivariateAnomalyDetection.scala 87.77% <0.00%> (+0.74%) ⬆️
...zure/synapse/ml/stages/PartitionConsolidator.scala 95.74% <0.00%> (+2.12%) ⬆️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 82.35% <0.00%> (+14.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mhamilton723 mhamilton723 merged commit 3d0f3f4 into microsoft:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants