clarify date comparisons when deleting old models/groups (#1733)

microsoft · Nov 21, 2022 · 952d1bd · 952d1bd
1 parent 6ea02bd
commit 952d1bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cognitive/src/test/scala/com/microsoft/azure/synapse/ml/cognitive/split1/FaceSuite.scala b/cognitive/src/test/scala/com/microsoft/azure/synapse/ml/cognitive/split1/FaceSuite.scala
@@ -278,7 +278,7 @@ class IdentifyFacesSuite extends TransformerFuzzing[IdentifyFaces] with Cognitiv
       try {
         val pgDateString = pgi.personGroupId.replaceFirst("group", "")
         val pgDate = LocalDateTime.parse(pgDateString, DateTimeFormatter.ofPattern(timeFormat))
-        if (twoDaysAgo.compareTo(pgDate) <= 0) {
+        if (pgDate.isBefore(twoDaysAgo)) {
           PersonGroup.delete(pgi.personGroupId)
           println(s"deleted group $pgi")
         }

diff --git a/...a/com/microsoft/azure/synapse/ml/cognitive/split4/MultivariateAnamolyDetectionSuite.scala b/...a/com/microsoft/azure/synapse/ml/cognitive/split4/MultivariateAnamolyDetectionSuite.scala
@@ -263,7 +263,7 @@ class FitMultivariateAnomalySuite extends EstimatorFuzzing[FitMultivariateAnomal
     models.foreach { modelId =>
       val lastUpdated = MADUtils.madGetModel(url, modelId, anomalyKey).parseJson.asJsObject.fields("lastUpdatedTime")
       val lastUpdatedTime = stringToTime(lastUpdated.toString().replaceAll("\"", ""))
-      if (lastUpdatedTime.compareTo(twoDaysAgo) <= 0) {
+      if (lastUpdatedTime.isBefore(twoDaysAgo)) {
         println(s"Deleting $modelId")
         MADUtils.madDelete(modelId, anomalyKey, anomalyLocation)
       }