Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::fill and ranges::fill_n #904

Merged
merged 7 commits into from
Jul 2, 2020
Merged

Implement ranges::fill and ranges::fill_n #904

merged 7 commits into from
Jul 2, 2020

Conversation

ahanamuk
Copy link
Contributor

No description provided.

@ahanamuk ahanamuk added the cxx20 C++20 feature label Jun 17, 2020
@ahanamuk ahanamuk requested a review from a team as a code owner June 17, 2020 16:00
@ghost
Copy link

ghost commented Jun 17, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@CaseyCarter CaseyCarter mentioned this pull request Jun 17, 2020
Closed
StephanTLavavej
StephanTLavavej requested changes Jun 17, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej reviewed Jun 18, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
CaseyCarter
CaseyCarter requested changes Jun 18, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter mentioned this pull request Jun 18, 2020
Merged
CaseyCarter
CaseyCarter approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo clang-format complaining about stl/inc/algorithm.

@StephanTLavavej StephanTLavavej changed the title Fill algo Implement ranges::fill and ranges::fill_n Jun 21, 2020
@StephanTLavavej
Copy link
Member

Updated the PR title to match the other ranges PRs (also #905).

@mnatsuhara mnatsuhara mentioned this pull request Jun 22, 2020
Merged
mnatsuhara
mnatsuhara reviewed Jun 22, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor stylistic comments and a bit of test coverage requested.

stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Show resolved Hide resolved
@CaseyCarter CaseyCarter self-requested a review June 26, 2020 15:17
CaseyCarter
CaseyCarter requested changes Jun 26, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill/test.cpp Outdated Show resolved Hide resolved
tests/std/include/range_algorithm_support.hpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej requested changes Jun 29, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be ready to merge after one more round of very small fixes!

stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_fill_n/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Jun 29, 2020
@CaseyCarter CaseyCarter merged commit 123b2b2 into microsoft:master Jul 2, 2020
@CaseyCarter
Copy link
Member

Thanks for your contribution which fills a void in <algorithm>!

@CaseyCarter CaseyCarter removed their assignment Jul 2, 2020
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara left review comments

@miscco miscco miscco left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahanamuk @StephanTLavavej @CaseyCarter @miscco @mnatsuhara