-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atomic_ref (#2, p0019r8) #843
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Still requires to handle generic atomic by a lock via contention table instead of internal lock. |
So two main issues with this change is with mutex for bad size:
Due to the first issue it may make sense to make the best of the situation, and cache mutex reference in Note that I'm assuming that embedded by value spinlock is not an option because independently constructed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, very minor nitpicks.
Co-authored-by: Stephan T. Lavavej <[email protected]>
Thanks for contributing my favorite C++20 feature :D |
# Conflicts: # stl/inc/yvals.h
Fixes #2
Seems like it that simple to reuse existing atomic bases.