Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-4112 has-arrow should require operator->() to be const-qualified #5152

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Implement LWG-4112 has-arrow should require operator->() to be const-qualified #5152

merged 4 commits into from
Dec 5, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Nov 27, 2024 •
edited
Loading

Fixes #5116. This affects filter_view & join_view's iterators.

Skipped libcxx test:

  • std/ranges/range.adaptors/range.join/range.join.iterator/arrow.pass.cpp

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 27, 2024 13:14
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Nov 27, 2024
@CaseyCarter CaseyCarter self-assigned this Nov 27, 2024
CaseyCarter
CaseyCarter approved these changes Nov 27, 2024
View reviewed changes
tests/std/tests/P0896R4_views_filter/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_filter/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_join/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_join/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Nov 27, 2024
@CaseyCarter
Copy link
Member

CaseyCarter commented Nov 27, 2024 •
edited
Loading

I pushed a commit to remove the unused function bodies and data members from the two implementations of arrowed_iterator which are used only in unevaluated operands. There's no need to have more code around to read and maintain if we don't actually need it.

@CaseyCarter CaseyCarter mentioned this pull request Nov 26, 2024
Open
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Nov 27, 2024
@StephanTLavavej StephanTLavavej self-assigned this Dec 3, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a4ae6c3 into microsoft:main Dec 5, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

I can haz arrow? 🐈 🍔 😋

@frederick-vs-ja frederick-vs-ja deleted the lwg-4112 branch December 5, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpplearner cpplearner cpplearner left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-4112 has-arrow should require operator->() to be const-qualified
4 participants
@frederick-vs-ja @CaseyCarter @StephanTLavavej @cpplearner