Implement LWG-4014 LWG-3809 changes behavior of some existing std::subtract_with_carry_engine code
#5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subtract_with_carry_engine: https://godbolt.org/z/e84Ws7Y8c (Boost 1.60.0 was Dec 2015.) mt19937(0): https://godbolt.org/z/7haGYYenn (Boost 1.52.0 was Nov 2012.)
StephanTLavavej
approved these changes
Nov 26, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🎲 ➖ 🔀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5133.
The behavior change was indicated by changes in the test file. LWG-4014 restores the old behavior, which can be indicated by reverting of the change in that line in the test file.