Implement LWG-4135 The helper lambda of std::erase for list should specify return type as bool
#5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exercises both adjacent and non-adjacent removals, inspects the container's entire contents again, and is somewhat clearer about distinguishing element values from the number of elements removed. (In the `std::erase` case, the container no longer contains odd elements, so removing 5 elements is clear.) This is, of course, the first digits of pi.
StephanTLavavej
approved these changes
Dec 2, 2024
|
Thanks! 😻 I pushed significant test changes, please double-check. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🐑 📝 👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves test coverage for P1209R0 by separating related cases to a new test file, which is actually the major part of this PR.
Fixes #5117.