Internally remove workaround in Dev09_056375_locale_cleanup
#5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FreeLibrary` call made the ASan runtime do Very Bad Things when statically linking the STL. The ASan bug was fixed by MSVC-PR-582781. Let's enable test coverage internally to prevent regressions until the fix ships in 17.13p2. Fixes VSO-2046190/AB#2046190.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Nov 20, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🌏 🧹 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FreeLibrarycall made the ASan runtime do Very Bad Things when statically linking the STL. The ASan bug was fixed by AddressSanitizer-PR-582781 (merged intoprod/beby MSVC-PR-585734 on 2024-10-16). Let's enable test coverage internally to prevent regressions until the fix ships in 17.13p2.Fixes VSO-2046190/AB#2046190.
(I've done some extra validation with the trunk compiler as well to make sure this won't become a problem when merging.)