Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific assertion for unlocking mutex not owned by the current thread #5099

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

AlexGuteniev
Copy link
Contributor

Inspired by #4418 (comment)

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner November 19, 2024 08:41
stl/src/mutex.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Nov 19, 2024
@StephanTLavavej StephanTLavavej self-assigned this Nov 19, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9b8a09a into microsoft:main Nov 22, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for improving this diagnostic! 🔒 🔑 🔓

@AlexGuteniev AlexGuteniev deleted the mutex-is-not-semaphore branch November 22, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants