Enforce assign_range() mandates for sequence containers
#5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Nov 14, 2024
CaseyCarter
approved these changes
Nov 14, 2024
StephanTLavavej
approved these changes
Nov 15, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this bug and increasing the STL's conformance! 📈 🐞 🛠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5076 by statically asserting the mandates for the sequence containers
deque,forward_list,list, andvector.basic_stringalso defines a functionassign_range(), but I did not add a static assert to it:basic_stringincludes its own specification ofassign_range()which does not provide for any Mandates ([string.assign]/16). Besides, the standard doesn't listbasic_stringamong the sequence containers in [sequence.reqmts]/1, so it appears to me that [sequence.reqmts]/60 doesn't apply directly tobasic_string.