Refactor _Copy_memmove and _Copy_memmove_n
#5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
There's a redundant recalculation of `n` in our existing implementation of `_Copy_memmove_n` which calls `_Copy_memmove`. Eliminate that redundancy by extracting the commonality into a new function `_Copy_memmove_tail` called by both `_Copy_memmove` and `_Copy_memmove_n`. This also corrects an error in `_Copy_memmove_n` where it was adding a `size_t` directly to an iterator.
CaseyCarter
force-pushed
the
copy_memmove
branch
from
2593031 to
4c0da21
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…gative counts * `ranges::copy_n` takes a difference argument that it was blindly converting to `size_t` Drive-by: `_Copy_n_unchecked4` no longer needs to guard its `_STL_INTERNAL_STATIC_ASSERT(_Integer_like<_SizeTy>);` for `_HAS_CXX20` since microsoft#5015 defined `_Integer_like` in pre-20 modes.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
commented
Oct 30, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Make MyIterator a template so `src` can be const.
StephanTLavavej
approved these changes
Nov 2, 2024
|
Thanks! 😻 I pushed various nitpicks and a significant expansion of test coverage - please meow if you have any objections, I was a bit more daring than usual. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for memmoving these bugs out of our implementation! 🐞 🚚 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Copy_memmove_nadds asize_tdirectly to an iterator.ranges::copy_nconvertsntosize_twithout verifying it is non-negative.nin our existing implementation of_Copy_memmove_nwhich calls_Copy_memmove. Eliminate that redundancy by extracting the commonality into a new function_Copy_memmove_tailcalled by both_Copy_memmoveand_Copy_memmove_n._Copy_n_unchecked4should verify its precondition thatn >= 0. Drive-by: We can unconditionally_STL_INTERNAL_STATIC_ASSERT(_Integer_like<_SizeTy>)since Unwrapping output iterators in range algorithms #5015 defined_Integer_likein pre-20 modes