Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<regex>: Fix goofy message for error_badbrace #5025

Merged
merged 1 commit into from
Oct 21, 2024
Merged

<regex>: Fix goofy message for error_badbrace #5025

merged 1 commit into from
Oct 21, 2024

Conversation

5AIPAVAN
Copy link
Contributor

Fixes #4993
updated line 502 in regex.cpp
from : "contained an invalid range in a { expression }."
to : "contained an invalid range in a {} expression."

@5AIPAVAN 5AIPAVAN requested a review from a team as a code owner October 17, 2024 16:12
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 17, 2024
@StephanTLavavej StephanTLavavej changed the title updated line 502 in regex.cpp to solve issue <regex>: Goofy message for error_badbrace #4993 <regex>: Fix goofy message for error_badbrace Oct 17, 2024
@StephanTLavavej
Copy link
Member

I've updated the PR title to fix several issues:

  • The <regex> header is being edited here, not a file named regex.cpp
  • PR titles shouldn't mention hyper-details like line numbers
  • PR titles don't need to mention issue numbers; these are meaningless when viewing commit history

@StephanTLavavej StephanTLavavej self-assigned this Oct 21, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 27b1f88 into microsoft:main Oct 21, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for this diagnostic improvement and congrats on your second microsoft/STL commit! 🎉 🎉 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<regex>: Goofy message for error_badbrace
2 participants
@5AIPAVAN @StephanTLavavej