Reduce inclusion for <queue>, <stack>, <stacktrace>, and <thread>
#5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
fmt-inclusion-2
branch
from
c1efde7 to
6b60cc1
Compare
Declare `_Throw_format_error` above `basic_format_parse_context`, following the order of their definitions in `<__msvc_ranges_tuple_formatter.hpp>`.
tests/std/tests/P2286R8_text_formatting_header_queue/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_header_vector/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Oct 10, 2024
|
Thanks for this very complicated but careful transformation! 😻 I found only a few issues and pushed changes - please double-check. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this heroic throughput improvement! 🚀 🖥️ 📊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since C++23,
<queue>,<stack>,<stacktrace>,<thread>, and<vector>are required to provideformatterspecializations. Previously,<format>was included by several headers to allow theformatterspecializations to be properly defined. This PR splits out the necessary parts forformatterspecializations and puts allformatterspecializations other than those provided by<__msvc_formatter.hpp>into a new internal header<__msvc_ranges_tuple_formatter.hpp>.The
formattableconcept is critical for these C++23 formatters. To ensure thatformattablestill works correctly, the definitions ofbasic_format_parse_context,basic_format_context,basic_format_arg,basic_format_argsetc. are also moved to<__msvc_ranges_tuple_formatter.hpp>.Newly added test files tests that these new
formatterspecializations are defined in the corresponding headers.Notes:
formatter<stacktrace_entry>::parseis templatized to allow_Fill_align_and_width_formatter_parseto be declared but not defined when including<stacktrace>.<__msvc_ranges_tuple_formatter.hpp>.