Fix constraint on unique_ptr<T, D>(auto_ptr<U>&&)
#4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per suggestion of Howard Hinnant on the LWG reflector. We initialize `unique_ptr`'s stored `pointer` with the result of calling `release()` on the `auto_ptr`, which returns `U`, so the correct constraint is to require `U*` to be convertible to `pointer`.
StephanTLavavej
approved these changes
Aug 30, 2024
|
Approved with uncontrollable vomiting 🤮 😹 |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🧪 ☣️ ☠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion of Howard Hinnant on the LWG reflector. We initialize
unique_ptr's storedpointerwith the result of callingrelease()on theauto_ptr.release()has typeU*, so the correct constraint is to requireU*to be convertible topointer.STL will probably laugh himself to tears before rejecting this PR, but it's probably the only chance I'll ever get to fix an
auto_ptr-related bug so here it is =)