Make the test suite more friendly to Clang 19 #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix for regression in `P2268R8_text_formatting_range_formatter` I'm applying a perma-workaround because I suspect this is actually ill-formed, but am not motivated to investigate. GCC also rejects this usage. * Workaround LLVM-104189 in `P2374R4_views_cartesian_product_recommended_practices`` * Comment that LLVM-95311 is fixed in 19.1.0-rc3 on the `FAIL` line in `expected_results.txt` for `std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp`. This allows Clang 19 to pass the test suite with the sole exception of the `has_unique_object_representations` test that `FAIL`s with Clang 17.
StephanTLavavej
approved these changes
Aug 25, 2024
|
Thanks! I pushed a conflict-free merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for getting us ready for Future Technology! 🪄 🎉 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2268R8_text_formatting_range_formatterI'm applying a perma-workaround because I suspect this is actually ill-formed, but am not motivated to investigate. GCC also rejects this usage.P2374R4_views_cartesian_product_recommended_practicesFAILline inexpected_results.txtforstd/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp.This allows Clang 19 to pass the test suite with the sole exception of the
has_unique_object_representationstest thatFAILs with Clang 17. I expect little to no change in the 19.1.0 release (per https://discourse.llvm.org/t/llvm-19-1-0-rc3-released/80802).