-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block building Tests in wrong command prompt #4717
Conversation
Thanks, this is super awesome and will prevent a common problem for contributors! 😻 I pushed a major simplification of the logic and improved the output:
This works because CMake's def assert_same_platform_for_build_and_test():
build_platform = 'x64'
test_platform = os.getenv('Platform', default='') I also verified the reverse failure case, and successful cases. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for preventing this common early headache for contributors! 🩹 🏥 🎉 |
Fixes #4639