-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<format>
: Copy basic_format_args
in tuple
formatters when needed
#4681
Merged
StephanTLavavej
merged 3 commits into
microsoft:main
from
frederick-vs-ja:formatter-tuple-copy-args
May 30, 2024
Merged
<format>
: Copy basic_format_args
in tuple
formatters when needed
#4681
StephanTLavavej
merged 3 commits into
microsoft:main
from
frederick-vs-ja:formatter-tuple-copy-args
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't really copy the arguments, right? It copies |
frederick-vs-ja
changed the title
May 22, 2024
<format>
: Copy format arguments in tuple
formatters when needed<format>
: Copy basic_format_args
in tuple
formatters when needed
StephanTLavavej
approved these changes
May 29, 2024
Thanks! I pushed a conflict-free merge with |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing the runtime correctness of one of the most popular new features! 🪄 🐈 🐱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4651.
Also
_Fmt_it
,_Fmt_wit
,format_context
, andwformat_context
with consistent alias templates; andbasic_format_context
specializations can still be well-formed, despite that they can't be actually called.Notes: LWG-4061 is now tentatively ready (although this PR doesn't speculatively implements it yet). Thus it should be now clear that
basic_format_context
objects can only be created by implementations, not user codes.