Workaround for the interaction of constraints in expected and explicit template instantiation in permissive modes
#4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `<expected>`, check `is_swappable` as `is_swappable_v` can be buggy in permissive modes. - In `<iterator>`, avoid instantiation of `contiguous_iterator` for `istreambuf_iterator` and `ostreambuf_iterator`, which are instantiated in locale facets. Also adds test coverage for `expected` in permissive modes.
miscco
reviewed
May 8, 2024
tests/std/tests/GH_004657_expected_constraints_permissive/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 15, 2024
|
Thanks - a good workaround for a disgusting mode! 🤮 😹 I explored whether |
frederick-vs-ja
commented
May 15, 2024
tests/std/tests/GH_004657_expected_constraints_permissive/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 15, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for investigating and fixing this bug! 🛠️ 🚀 🐞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4657.
Works around DevCom-10652420, which is closed as Not a Bug. Works around/permissive-.<expected>, checkis_swappableasis_swappable_vcan be buggy in permissive modes.<iterator>, avoid instantiation ofcontiguous_iteratorforistreambuf_iteratorandostreambuf_iterator, which are instantiated in locale facets.Also adds test coverage for
expectedin permissive modes.