Avoid triggering ASan bug in Dev09_056375_locale_cleanup
#4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in `Dev09_056375_locale_cleanup` by leaving the DLL loaded in ASan instrumented statically-linked configs.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
STL-ASan-CI passed (after rerunning a sporadic x86 failure that I recorded in #4324). |
StephanTLavavej
changed the title
Dev09_056375_locale_cleanup
StephanTLavavej
approved these changes
May 7, 2024
|
Thanks! 😻 I updated the PR title to be more meaningful when scanning git history. |
zacklj89
approved these changes
May 8, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for scouting ahead and fixing this test for ASan before the next toolset update encountered it! 🎉 😻 🪄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid triggering VSO-2046190 in
Dev09_056375_locale_cleanupby leaving the DLL loaded in ASan instrumented statically-linked configs.This test is failing with 17.10p5 and current dev compilers, I suspect due to a change in the ASan runtime's interception of
memcpy. Recall thatmemcpyis part of VCRuntime, so statically-linked configs of this test have a copy ofmemcpylinked to the program and another copy ofmemcpylinked into the DLL. When the program unloads the DLL, I believe the ASan runtime's "pointer to actual memcpy" is left pointing into unallocated space where the DLL's copy used to be.I'm going to disable unloading the DLL for this case to avoid the problem until we can implement and ship a fix.