Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P2875R4 Undeprecate polymorphic_allocator::destroy #4532

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Implement P2875R4 Undeprecate polymorphic_allocator::destroy #4532

merged 2 commits into from
Mar 28, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4521. Also makes MSVC STL's polymorphic_allocator::destroy reject arrays (which is implicitly required by the standard wording).

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 25, 2024 17:16
@StephanTLavavej StephanTLavavej added the cxx26 C++26 feature label Mar 25, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 25, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit fbdcee4 into microsoft:main Mar 28, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for reviving this function and simplifying our implementation slightly! 🧟 ❌ 😸

@frederick-vs-ja frederick-vs-ja deleted the p2875r4 branch March 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx26 C++26 feature
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2875R4 Undeprecate polymorphic_allocator::destroy
2 participants
@frederick-vs-ja @StephanTLavavej