Remove attempt on unsized find vectorization... #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... except for 1-byte element, where we can still yield to `memchr` drive-by: signed coverage doesn't make difference here
StephanTLavavej
approved these changes
Mar 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
StephanTLavavej
approved these changes
Mar 18, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
AlexGuteniev
commented
Mar 19, 2024
StephanTLavavej
approved these changes
Mar 19, 2024
|
Thanks for fixing this regression and double-checking my changes! 🎉 😸 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... except for 1-byte element, where we can still yield to
memchrFixes #4485
Drive-by: signed coverage doesn't make difference here