-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<xutility>, <algorithm>: Add top level const on pointer parameters #4410
<xutility>, <algorithm>: Add top level const on pointer parameters #4410
Conversation
@microsoft-github-policy-service agree |
Changes for following functions still seem missing: In
In
|
Looks great, thanks! We merge PRs simultaneously to the MSVC-internal and GitHub repos in a semi-manual process, batching up PRs to save time. Your PR will be part of the next batch, likely later this week - I'll post comments as I mirror the PRs and then finally merge 'em. |
Thank you all, this process has been incredibly smooth for me! |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks again, and congratulations on your first microsoft/STL commit! 🎉 🥳 😸 This is expected to ship in VS 2022 17.10 Preview 3, and has been recorded in the STL Changelog. |
Closes #4385
This PR adds the top-level
const
to the_Ty* _First, _Ty* _Last
parameters for the following functions<algorithm>
:__std_minmax_element
,__std_minmax
<xutility>
:__std_find_trivial_unsized
,__std_min
,__std_max