ADL-proof implementation of uninitialized memory algorithms #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
changed the title
tests/std/tests/P2538R1_adl_proof_std_projected/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_001596_adl_proof_algorithms/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Feb 8, 2024
|
Thanks! I pushed a few changes, and I think this is ready to go now. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #4004. Towards #140 and #1596.
There's a separated commit addressing cases noted in #4367 (comment). Note that EDG currently incorrectly thinks
Derived*andBase*are subtractable under some conditions, whichshould beis reported as DevCom-10581519 and should be cited as VSO-XXXX.Unfortunately, currently there doesn't seem possible to verify that
_Copy_memcpy_distanceand_Copy_memcpy_countcalls are properly qualified, because the comparison betweentagged_derived<holder<incomplete>>*andunreachable_sentinel_tis ill-formed due to ADL.As a workaround for DevCom-10456452, the
__builtin_laundercall is qualified.This PR changes one line
_Destroy_rangein the same way as #4373, which shouldn't raise merge conflict IIUC.