-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<xiosbase>
: Remove non-conforming extension ios_base::hexfloat
#4345
<xiosbase>
: Remove non-conforming extension ios_base::hexfloat
#4345
Conversation
I previously thought that we couldn't remove I think that TR1-era |
Hmm, it seems that there're some codes on Github relying on |
I'm willing to break a little code at compile-time, when that code is non-portable and easily fixed. Many changes (including even deprecation warnings!) can result in compiler errors, it's just a question of their magnitude and how easy they are to deal with. That said, it would be an option to deprecate in 17.10, and wait until the next update for outright removal. I just don't think we need to move that slowly. |
<xiosbase>
: Deprecate non-conforming extension ios_base::hexfloat
<xiosbase>
: Remove non-conforming extension ios_base::hexfloat
Thanks! I've pushed a commit for removal. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for removing this hex from the Standard Library! 🪄 😸 🎉 |
Fixes #3296.
All uses of
ios_base::hexfloat
are replaced withios_base::scientific | ios_base::fixed
. Also, it seems to me that we should no longer testios_base::hexfloat
.If there's too many breaking for removing, we may fallback to deprecation.