-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable STL-ASAN-CI on PRs #4295
Conversation
.... but set the UI to require a maintainer comment to trigger.
/azp run STL-ASan-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
If and when we merge this change, we need to update the Wiki page that describes how to recreate the pipelines: there's a manual UI step needed to require a maintainer comment before running a pipeline. Without that setting, STL-ASan-CI will now run automatically on all PRs. As far as a can tell, there's no way to do this purely in YAML - which is why I didn't do so previously. I think the value of triggering the optional pipeline outweighs the annoyance of hand configuration. It's annoying to PR an ASan fix with no way to run the CI before merging. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for improving the ASAN experience! 📈 🎉 😸 |
I have updated the Wiki instructions. |
.... but set the UI to require a maintainer comment to trigger.