Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in the special snowflake windows version of the STL #4294

Merged

Conversation

barcharcraz
Copy link
Member

We change the size of critical sections based on _CRT_WINDOWS, but that macro is defined at build time only, and the size is relevant in our headers. We need to change the size based on UNDOCKED_WINDOWS_UCRT as well, which is defined in consumers.

I've added a pragma detect mismatch as well, but as its own commit. If we don't want it we don't have to accept that commit.

@barcharcraz barcharcraz requested a review from a team as a code owner January 4, 2024 00:29
stl/inc/xthreads.h Outdated Show resolved Hide resolved
stl/inc/xthreads.h Outdated Show resolved Hide resolved
stl/inc/xthreads.h Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter added bug Something isn't working high priority Important! labels Jan 4, 2024
@CaseyCarter
Copy link
Member

The build is failing with "C4384: pragma detect_mismatch should should only be used at global scope" which seems bogus to me. I suggest that you suppress the warning, verify that the detect_mismatch is correctly emitted into object files, and report the bogus warning to the compiler folks. Failing that, I suppose we'll have to have a separate conditional outside of the class scope just for the detect_mismatch.

@barcharcraz
Copy link
Member Author

The build is failing with "C4384: pragma detect_mismatch should should only be used at global scope" which seems bogus to me. I suggest that you suppress the warning, verify that the detect_mismatch is correctly emitted into object files, and report the bogus warning to the compiler folks. Failing that, I suppose we'll have to have a separate conditional outside of the class scope just for the detect_mismatch.

eagh, it is a bit shifty to have pragma detect mismatch in the middle of a class definition, I'll just move it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Important!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants