-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<random>
: Deprecate TR1 components in the std
namespace
#4284
<random>
: Deprecate TR1 components in the std
namespace
#4284
Conversation
c59d94a
to
43842a1
Compare
With some workaround reusing functions from bases.
43842a1
to
116ec63
Compare
subtract_with_carry inherits from _Swc_base whose operator== is strengthened.
mersenne_twister operator== is strengthened.
…lock_base _Discard_block_base operator== is NOT strengthened.
Thanks! 😻 I pushed a conflict-free merge with
That non-Standard operator (originally inherited from So I pushed commits to change our inheritance to
This results in nice cleanliness improvements (got rid of that non-Standard I checked that I definitely want a second maintainer approval here. |
…bution's non-Standard operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in principle, but I'll probably come after these comments later if you merge them =)
@CaseyCarter I pushed a commit to drop the pointless comments in newly added code. To avoid making this a grab-bag PR, I'm not touching pre-existing comments. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for deprecating this old machinery! 📈 🎉 😻 |
Towards #183 and #1002.
They are internally undeprecated when used as base classes. It seems that when
_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
is defined, warning should still be suppressed.TODO: need to investigate how to reuse functions from base classes.DONE