Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<format>: Fix STL internal check when formatting empty strings #4243

Merged
merged 1 commit into from
Dec 7, 2023
Merged

<format>: Fix STL internal check when formatting empty strings #4243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stl/inc/format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,9 @@ public:

constexpr _Unicode_codepoint_iterator(const _CharT* _First_val, const _CharT* _Last_val) noexcept
: _First(_First_val), _Last(_Last_val) {
_Next = _Decode_utf(_First, _Last, _Val)._Next_ptr;
if (_First != _Last) {
_Next = _Decode_utf(_First, _Last, _Val)._Next_ptr;
}
}

constexpr _Unicode_codepoint_iterator() = default;
Copy link
Member

@CaseyCarter CaseyCarter Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by WTF: Why does line 364 check _Last == _Other._Last when line 363 say it's a precondition? Should we fix that in another PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I assume I wrote the INTERNAL_CHECK on a different side of a coffee break than the return statement :D

Expand Down