Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups: Comments and strings #4117

Conversation

StephanTLavavej
Copy link
Member

  • Comments: Drop extra space.
  • Comments: Add them to #endif.
  • Comments: Drop "TRANSITION, requires expression support".
    • We use _Resettable_pointer twice; requires-expressions would be more verbose.
  • Comments: Fix capitalization typo.
  • Comments: Strengthen comment about ole32.dll.
  • String literals: Space before wrapping.
    • There were only a few places that weren't following our usual convention.
  • String literals: Unwrap.
    • This one was easier to read on a single line.

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Oct 23, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner October 23, 2023 15:36
@StephanTLavavej StephanTLavavej self-assigned this Oct 24, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2df039f into microsoft:main Oct 25, 2023
37 checks passed
@StephanTLavavej StephanTLavavej deleted the dry-cleaning-1-comments-and-strings branch October 25, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants