Tolerate 80-bit long double
in <xlocnum>
#4032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STL/stl/inc/xlocnum
Lines 615 to 622 in 8f67ece
This was introduced by MSVC-PR-113746 on 2018-03-29.
In DevCom-10465513, a user has reported that this prevents compilation with the Intel compiler in 80-bit
long double
mode. We don't support the Intel compiler and we especially don't support 80-bitlong double
, but we have an unofficial policy of avoiding gratuitous breakage when doing so is easy. In this case, merely omitting thestatic_assert
and explaining the assumption with a comment has no impact for MSVC/Clang users, and allows Intel 80-bit users to compile.I checked the STL for other occurrences and this appears to be the only such
static_assert
aboutlong double
's size in the product code.