-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update stl/inc/xtr1common: _Is_any_of_v #3933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use different style for comments:
Lines 984 to 988 in ed8150e
#if _HAS_CXX17 | |
return _Result; | |
#else // ^^^ _HAS_CXX17 / !_HAS_CXX17 vvv | |
(void) _Result; | |
#endif // _HAS_CXX17 |
but I don't think it's worth to rerun tests to fix the comments.
Yeah, fold-expression could have better throughput.
Sorry, I was so reckless. |
This was my first attempt to submit a pr to a project like this, and there were a lot of things I didn't do well |
The CI will be restarted later. I have no idea what's wrong: "Received request to deprovision: The request was cancelled by the remote provider." But your code is fine. No changes needed. |
We use so-called "spot" VMs in Azure to minimize CI costs. They cost less, but are subject to being pulled out from underneath us without warning and reallocated to full paying customers. |
The MSVC compiler actually internally optimizes both |
We use |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for improving compiler throughput here, and congratulations on your first microsoft/STL commit! 🎉 😻 🥳 |
This is a very simple modification. The original _Is_any_of_v produces a lot of bloated unrolling. Using fold-expression is a better alternative. Because the change was so simple, I didn't issue it, and the tests were fine.