Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU previously macroized these reserved names. This was fixed by unicode-org/icu#1555 on 2021-02-01, but old versions of ICU are still being used by various projects. Let's avoid these names for now. I haven't added test coverage because the UCRT uses some of these reserved names (which it's getting away with, due to the specific order in which headers are being included).
Fixes VSO-1837381 "[RWC][prod/fe][Regression] PDFium failed with error C2209:
'std::_Aligned_storage_t<64,8>'
: aliases cannot be used in constructor declarations"._Cs
=>_Cs_storage
mutex.cpp
.<mutex>
: Make_Mtx_internal_imp_mirror
more closely match_Mtx_internal_imp_t
#3763. We were getting away with the others._No
=>_Nope
<deque>
_Is_bidi
consistent with<format>
_Add_newline
,<xlocale>
_Case_sensitive
, etc._Mn
=>_Min_
, also_Mx
=>_Max_
for consistency_Cc
=>_Cx
, also_Yy
=>_Yx
and_Nn
=>_Nx
for consistency_Pi
=>_Pi_val