Remove some workaround for Clang #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
May 22, 2023
There was a problem hiding this comment.
I'm approving despite thinking that maybe we should keep around _Bci_order and _Not_bci_order; I'd like to see what other people think. I'm also applying some changes to the pre-existing const range access CPO constraints that may someday help the compiler provide more targeted error messages.
barcharcraz
approved these changes
May 23, 2023
StephanTLavavej
approved these changes
May 25, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for these cleanups and helping to lock in a higher level of conformance! 🧹 📈 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM-47414, LLVM-51580, LLVM-55945, and LLVM-56379 should have been fixed in Clang16. Let's remove the workarounds.